Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
+ Coverage 96.42% 98.9% +2.47%
=========================================
Files 1 1
Lines 28 91 +63
Branches 5 24 +19
=========================================
+ Hits 27 90 +63
Misses 1 1
Continue to review full report at Codecov.
|
Author
|
@TheLarkInn I am planning on looking through the issues and see which of them are resolved by this PR. Some of the other PRs already define new tests for the edge cases they fix (based on the regexp approach). So I am planning on adding those tests to the spec as well, just to make sure that the AST approach really covers them |
|
This would resolve my issue where the regex fails on properly quoted JSON object keys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54
This pull request uses typescript to construct an AST and find the positions where the
require()sshould be placed. It should fix several issues and edge cases caused by the regexp approach.All tests are passing and one new test (adding the possibility to use template literals) was added.